[TS migration] Migrate WorkspaceReimburse Page #35399

ruben-rebelo · 2024-01-30T13:16:37Z

Details

[TS migration] Migrate WorkspaceReimburse page to TypeScript

Fixed Issues

$ #25211
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Test WorkspaceReimburse Pages:

Log in into an account that is a workspace admin
Navigate to Workspace
Go to Settings -> Reimburse
All the screen button work
Pressing

Offline tests

N/A

QA Steps

Verify that no errors appear in the JS console

Same as in the Tests section.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-native.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios-native.mp4

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

macos-web.mp4

MacOS: Desktop

macos-desktop.mov

melvin-bot · 2024-01-30T13:16:42Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

VickyStash · 2024-01-30T14:12:36Z

src/components/Picker/BasePicker.tsx

+            if (onInputChange) {
+                onInputChange(inputValue);
+            }


Suggested change

if (onInputChange) {

onInputChange(inputValue);

}

onInputChange?.(inputValue);

VickyStash · 2024-01-30T14:12:39Z

src/components/Picker/BasePicker.tsx

+        if (onInputChange) {
+            onInputChange(inputValue, index);
+        }


Suggested change

if (onInputChange) {

onInputChange(inputValue, index);

}

onInputChange?.(inputValue, index);

VickyStash · 2024-01-30T14:18:17Z

src/pages/workspace/reimburse/WorkspaceReimburseView.tsx


-    const getUnitLabel = useCallback((value) => translate(`common.${value}`), [translate]);
+    const getUnitLabel = useCallback((value: Unit) => translate(`common.${value}`), [translate]);


Suggested change

const getUnitLabel = useCallback((value: Unit) => translate(`common.${value}`), [translate]);

const getUnitLabel = useCallback((value: Unit): string => translate(`common.${value}`), [translate]);

VickyStash · 2024-01-30T14:20:56Z

src/pages/workspace/reimburse/WorkspaceReimburseView.tsx

-    const distanceCustomUnit = _.find(lodashGet(props.policy, 'customUnits', {}), (unit) => unit.name === CONST.CUSTOM_UNITS.NAME_DISTANCE);
-    const distanceCustomRate = _.find(lodashGet(distanceCustomUnit, 'rates', {}), (rate) => rate.name === CONST.CUSTOM_UNITS.DEFAULT_RATE);
-    const {translate, toLocaleDigit} = props;
+    const [currentRatePerUnit, setCurrentRatePerUnit] = useState<string | undefined>('');


Suggested change

const [currentRatePerUnit, setCurrentRatePerUnit] = useState<string | undefined>('');

const [currentRatePerUnit, setCurrentRatePerUnit] = useState<string>('');

VickyStash · 2024-01-30T14:22:13Z

src/pages/workspace/reimburse/WorkspaceReimburseView.tsx

+        if (!customUnitRate) {
+            return undefined;
+        }


Let's update getUnitRateValue typing instead, it looks like it already can handle the case where customUnitRate is undefined

Suggested change

if (!customUnitRate) {

return undefined;

}

src/pages/workspace/reimburse/WorkspaceReimbursePage.tsx

VickyStash · 2024-01-30T14:38:55Z

src/libs/actions/Policy.ts

+type UpdateCustomUnit = {
+    customUnitID: string;
+    name: string;
+    attributes: Attributes;
+    rates: Rate;
+};


Also maybe I'd rename it to NewCustomUnit or CustomUnitUpdate

Suggested change

type UpdateCustomUnit = {

customUnitID: string;

name: string;

attributes: Attributes;

rates: Rate;

};

type UpdateCustomUnit = CustomUnit & {

rates: Rate;

};

VickyStash · 2024-01-30T14:44:00Z

src/pages/workspace/reimburse/WorkspaceRateAndUnitPage.tsx

+        Navigation.goBack(ROUTES.WORKSPACE_REIMBURSE.getRoute(policy?.id ?? ''));
+    };
+
+    const validate = (values: OnyxFormValuesFields<typeof ONYXKEYS.FORMS.WORKSPACE_RATE_AND_UNIT_FORM>) => {


Let's add return type

VickyStash · 2024-01-30T14:46:27Z

src/pages/workspace/reimburse/WorkspaceRateAndUnitPage.tsx

+                            role={CONST.ROLE.PRESENTATION}
+                            inputID="rate"
+                            containerStyles={[styles.mt4]}
+                            defaultValue={distanceCustomRate ? PolicyUtils.getUnitRateValue(distanceCustomRate, toLocaleDigit) : ''}


Same, update getUnitRateValue typing instead

VickyStash · 2024-01-30T14:46:45Z

src/pages/workspace/reimburse/WorkspaceRateAndUnitPage.tsx

+                            maxLength={12}
+                        />
+
+                        <View style={[styles.mt4]}>


Suggested change

<View style={[styles.mt4]}>

<View style={styles.mt4}>

rezkiy37 · 2024-01-31T16:18:07Z

src/pages/workspace/reimburse/WorkspaceReimburseSection.tsx

    const hasVBA = achState === BankAccount.STATE.OPEN;
-    const reimburseReceiptsUrl = `reports?policyID=${props.policy.id}&from=all&type=expense&showStates=Archived&isAdvancedFilterMode=true`;
-    const isLoading = lodashGet(props.reimbursementAccount, 'isLoading', false);
+    const reimburseReceiptsUrl = `reports?policyID=${policy?.id ?? ''}&from=all&type=expense&showStates=Archived&isAdvancedFilterMode=true`;


Can we extract this url to CONST?

Do you mean add this into the CONST file?

This reverts commit 4feb092.

VickyStash · 2024-02-01T13:45:17Z

src/pages/workspace/reimburse/WorkspaceReimburseView.tsx

-        lastModified: PropTypes.number,
-    }).isRequired,
-
+type WorkspaceReimburseViewOnyxProps = {
    /** From Onyx */


Suggested change

/** From Onyx */

VickyStash · 2024-02-01T13:54:41Z

src/pages/workspace/reimburse/WorkspaceRateAndUnitPage.tsx

+            },
+        };
+
+        Policy.updateWorkspaceCustomUnitAndRate(policy?.id ?? '', distanceCustomUnit, newCustomUnit, parseInt(policy?.lastModified ?? '', 2));


Please update updateWorkspaceCustomUnitAndRate typing instead

Suggested change

Policy.updateWorkspaceCustomUnitAndRate(policy?.id ?? '', distanceCustomUnit, newCustomUnit, parseInt(policy?.lastModified ?? '', 2));

Policy.updateWorkspaceCustomUnitAndRate(policy?.id ?? '', distanceCustomUnit, newCustomUnit, policy?.lastModified);

VickyStash · 2024-02-01T13:59:55Z

src/pages/workspace/reimburse/WorkspaceRateAndUnitPage.tsx

+        if (!rateValueRegex.test(values.rate.toString()) || values.rate.toString() === 'Nan') {
+            errors.rate = 'workspace.reimburse.invalidRateError';
+        } else if (NumberUtils.parseFloatAnyLocale(values.rate.toString()) <= 0) {
+            errors.rate = 'workspace.reimburse.lowRateError';
+        }


Let's have the old logic and update rate type in values to string instead

Suggested change

if (!rateValueRegex.test(values.rate.toString()) || values.rate.toString() === 'Nan') {

errors.rate = 'workspace.reimburse.invalidRateError';

} else if (NumberUtils.parseFloatAnyLocale(values.rate.toString()) <= 0) {

errors.rate = 'workspace.reimburse.lowRateError';

}

if (!rateValueRegex.test(values.rate) || values.rate === '') {

errors.rate = 'workspace.reimburse.invalidRateError';

} else if (NumberUtils.parseFloatAnyLocale(values.rate) <= 0) {

errors.rate = 'workspace.reimburse.lowRateError';

}

# Conflicts: # src/ONYXKEYS.ts # src/pages/workspace/reimburse/WorkspaceRateAndUnitPage.js # src/pages/workspace/reimburse/WorkspaceReimbursePage.js # src/pages/workspace/reimburse/WorkspaceReimburseView.tsx # src/types/onyx/index.ts

# Conflicts: # src/ONYXKEYS.ts # src/libs/DistanceRequestUtils.ts # src/libs/actions/Policy.ts # src/pages/workspace/reimburse/WorkspaceReimburseView.tsx # src/types/onyx/Form.ts

VickyStash · 2024-02-08T15:18:57Z

src/libs/API/parameters/UpdateWorkspaceCustomUnitAndRateParams.ts

@@ -1,6 +1,6 @@
 type UpdateWorkspaceCustomUnitAndRateParams = {
    policyID: string;
-    lastModified: number;
+    lastModified?: number | string;


Suggested change

lastModified?: number | string;

lastModified?: string;

VickyStash · 2024-02-08T15:21:20Z

src/types/onyx/Form.ts


-type FormValueType = string | boolean | Date | OnyxCommon.Errors;
+type FormValueType = string | boolean | Date | number | OnyxCommon.Errors;


Why number it added, I've tried to remove it and ts check pass

VickyStash · 2024-02-08T15:23:56Z

src/pages/workspace/reimburse/WorkspaceReimburseView.tsx

+                <OfflineWithFeedback
+                    pendingAction={distanceCustomUnit?.pendingAction ?? distanceCustomRate?.pendingAction}
+                    shouldShowErrorMessages={false}
+                >
+                    <MenuItemWithTopDescription
+                        title={currentRatePerUnit}
+                        description={translate('workspace.reimburse.trackDistanceRate')}
+                        shouldShowRightIcon
+                        onPress={() => Navigation.navigate(ROUTES.WORKSPACE_RATE_AND_UNIT.getRoute(policy?.id ?? ''))}
+                        wrapperStyle={[styles.mhn5, styles.wAuto]}
+                        brickRoadIndicator={(distanceCustomUnit?.errors ?? distanceCustomRate?.errors) && CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR}
+                    />
+                </OfflineWithFeedback>


Why was it added, the code looks really similar to the code block above, maybe you did a mistake during conflicts resolution?

You are right! It was badly conflicts merge! Thank you!

VickyStash · 2024-02-08T15:27:50Z

src/pages/workspace/reimburse/WorkspaceRateAndUnitPage.tsx

+        const currentCustomUnitRate = Object.values(distanceCustomUnit?.rates ?? {}).find((r) => r.name === CONST.CUSTOM_UNITS.DEFAULT_RATE);
+        const unitID = distanceCustomUnit.customUnitID ?? '';
+        const unitName = distanceCustomUnit.name ?? '';
+        const rateNumValue = PolicyUtils.getNumericValue(rate, toLocaleDigit) as number;


What if we use Number(rateNumValue) instead of assertion?

Suggested change

const rateNumValue = PolicyUtils.getNumericValue(rate, toLocaleDigit) as number;

const rateNumValue = PolicyUtils.getNumericValue(rate, toLocaleDigit);

VickyStash · 2024-02-08T15:28:02Z

src/pages/workspace/reimburse/WorkspaceRateAndUnitPage.tsx

+            attributes: {unit},
+            rates: {
+                ...currentCustomUnitRate,
+                rate: rateNumValue * CONST.POLICY.CUSTOM_UNIT_RATE_BASE_OFFSET,


Suggested change

rate: rateNumValue * CONST.POLICY.CUSTOM_UNIT_RATE_BASE_OFFSET,

rate: Number(rateNumValue) * CONST.POLICY.CUSTOM_UNIT_RATE_BASE_OFFSET,

melvin-bot · 2024-02-13T09:34:23Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2024-02-15T14:49:13Z

Will get to this one tomorrow.

Ollyws · 2024-02-16T14:52:43Z

@ruben-rebelo Could you have a look at those merge conflicts? Thanks!

Ollyws · 2024-02-22T10:07:58Z

@ruben-rebelo Seems there are some lint/typecheck errors.

# Conflicts: # src/ONYXKEYS.ts # src/libs/PolicyUtils.ts # src/libs/actions/Policy.ts # src/pages/workspace/reimburse/WorkspaceReimburseView.tsx # src/types/onyx/Form.ts # src/types/onyx/Policy.ts # src/types/onyx/index.ts

ruben-rebelo · 2024-02-22T14:56:56Z

@Ollyws It seems the conflicts were wrongly resolved.
I've reverted the merge and resolved the conflicts again.
Please take a look

Ollyws · 2024-02-23T11:42:00Z

@ruben-rebelo Still got a typecheck error there if you could take a look, thanks!

Ollyws · 2024-02-27T11:32:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws

LGTM.

melvin-bot · 2024-02-27T11:34:13Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25211 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

Ollyws · 2024-02-27T11:35:00Z

@ruben-rebelo could you please run npm run prettier to get rid of the lint error, thanks!

# Conflicts: # src/pages/workspace/reimburse/WorkspaceReimburseSection.tsx

ruben-rebelo · 2024-03-04T09:21:01Z

@Ollyws Friendly bump

Ollyws · 2024-03-04T09:30:39Z

Just waiting on @tylerkaraszewski's review.

# Conflicts: # src/libs/DistanceRequestUtils.ts

tylerkaraszewski · 2024-03-13T19:17:14Z

Conflicts.

# Conflicts: # src/libs/PolicyUtils.ts

ruben-rebelo · 2024-03-18T09:21:37Z

@tylerkaraszewski Conflicts resolved. Thanks!

tylerkaraszewski · 2024-03-18T17:13:51Z

Tests are currently failing.

tylerkaraszewski · 2024-03-20T22:57:53Z

Also, conflicts.

# Conflicts: # src/libs/PolicyUtils.ts

ruben-rebelo · 2024-03-21T12:51:40Z

@tylerkaraszewski PR updated and conflicts resolved

tylerkaraszewski · 2024-03-21T16:12:35Z

Performance tests aren't currently passing.

fabioh8010 · 2024-03-22T07:45:03Z

@ruben-rebelo Could you check this? Thanks!

ruben-rebelo · 2024-03-22T17:50:34Z

@tylerkaraszewski It needed merge with main. Tests are now passing.

OSBotify · 2024-03-22T19:51:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

VickyStash reviewed Jan 30, 2024

View reviewed changes

rezkiy37 reviewed Jan 31, 2024

View reviewed changes

[TS Migration] Migrate WorkspaceCard to Typescript

4feb092

ruben-rebelo force-pushed the ts-migration/workspacereimburse-page branch from 6dcbdc6 to 4feb092 Compare February 1, 2024 09:47

ruben-rebelo added 3 commits February 1, 2024 10:15

[TS migration] Migrate WorkspaceReimburse page

b974629

Revert "[TS Migration] Migrate WorkspaceCard to Typescript"

f51dfad

This reverts commit 4feb092.

[TS migration][WorkspaceReimburse] Missing imports

3a7ad1e

VickyStash reviewed Feb 1, 2024

View reviewed changes

ruben-rebelo added 3 commits February 2, 2024 09:39

[TS migration][WorkspaceReimburse] Code improvements

d11c98a

Merge branch 'main' into ts-migration/workspacereimburse-page

e66017b

# Conflicts: # src/ONYXKEYS.ts # src/libs/DistanceRequestUtils.ts # src/libs/actions/Policy.ts # src/pages/workspace/reimburse/WorkspaceReimburseView.tsx # src/types/onyx/Form.ts

VickyStash reviewed Feb 8, 2024

View reviewed changes

[TS migration][WorkspaceReimburse] Code improvements

34135a2

blazejkustra approved these changes Feb 12, 2024

View reviewed changes

ruben-rebelo marked this pull request as ready for review February 13, 2024 09:34

ruben-rebelo requested a review from a team as a code owner February 13, 2024 09:34

melvin-bot bot requested review from Ollyws and removed request for a team February 13, 2024 09:34

ruben-rebelo force-pushed the ts-migration/workspacereimburse-page branch from da439a9 to 34135a2 Compare February 22, 2024 14:53

Merge branch 'main' into ts-migration/workspacereimburse-page

7cd655d

# Conflicts: # src/ONYXKEYS.ts # src/libs/PolicyUtils.ts # src/libs/actions/Policy.ts # src/pages/workspace/reimburse/WorkspaceReimburseView.tsx # src/types/onyx/Form.ts # src/types/onyx/Policy.ts # src/types/onyx/index.ts

[TS migration][WorkspaceReimburse] Ts issues fix

458be5e

Ollyws approved these changes Feb 27, 2024

View reviewed changes

ruben-rebelo added 2 commits February 27, 2024 12:40

[TS migration][WorkspaceReimburse] Lint

aafd0e5

Merge branch 'main' into ts-migration/workspacereimburse-page

a04d571

# Conflicts: # src/pages/workspace/reimburse/WorkspaceReimburseSection.tsx

joekaufmanexpensify requested a review from tylerkaraszewski March 11, 2024 15:10

Merge branch 'main' into ts-migration/workspacereimburse-page

c403cfa

# Conflicts: # src/libs/DistanceRequestUtils.ts

tylerkaraszewski previously approved these changes Mar 13, 2024

View reviewed changes

Merge branch 'main' into ts-migration/workspacereimburse-page

9cda701

# Conflicts: # src/libs/PolicyUtils.ts

ruben-rebelo dismissed tylerkaraszewski’s stale review via 9cda701 March 18, 2024 09:21

tylerkaraszewski previously approved these changes Mar 18, 2024

View reviewed changes

Merge branch 'main' into ts-migration/workspacereimburse-page

026d8e7

# Conflicts: # src/libs/PolicyUtils.ts

ruben-rebelo dismissed tylerkaraszewski’s stale review via 026d8e7 March 21, 2024 12:50

[TS migration][WorkspaceReimburse] TS issue fix

64cfc7e

Merge branch 'main' into ts-migration/workspacereimburse-page

1f240fd

tylerkaraszewski approved these changes Mar 22, 2024

View reviewed changes

tylerkaraszewski merged commit 107b378 into Expensify:main Mar 22, 2024
15 checks passed

github-actions bot mentioned this pull request Mar 27, 2024

Deploy Checklist: New Expensify 2024-03-27 #39033

Closed

allgandalf mentioned this pull request Mar 27, 2024

[HOLD for payment 2024-04-09] Web - Reimbursements - There is no offline indicator message on 'Reimbursements' page #39050

Closed

6 tasks

melvin-bot bot mentioned this pull request Mar 29, 2024

[$250] [HOLD for payment 2024-04-05] [TS migration] Migrate 'WorkspaceReimburse' page to TypeScript #25211

Closed


		const getUnitLabel = useCallback((value) => translate(`common.${value}`), [translate]);
		const getUnitLabel = useCallback((value: Unit) => translate(`common.${value}`), [translate]);

	const [currentRatePerUnit, setCurrentRatePerUnit] = useState<string \| undefined>('');
	const [currentRatePerUnit, setCurrentRatePerUnit] = useState<string>('');

	Policy.updateWorkspaceCustomUnitAndRate(policy?.id ?? '', distanceCustomUnit, newCustomUnit, parseInt(policy?.lastModified ?? '', 2));
	Policy.updateWorkspaceCustomUnitAndRate(policy?.id ?? '', distanceCustomUnit, newCustomUnit, policy?.lastModified);


		type FormValueType = string \| boolean \| Date \| OnyxCommon.Errors;
		type FormValueType = string \| boolean \| Date \| number \| OnyxCommon.Errors;

	const rateNumValue = PolicyUtils.getNumericValue(rate, toLocaleDigit) as number;
	const rateNumValue = PolicyUtils.getNumericValue(rate, toLocaleDigit);

	rate: rateNumValue * CONST.POLICY.CUSTOM_UNIT_RATE_BASE_OFFSET,
	rate: Number(rateNumValue) * CONST.POLICY.CUSTOM_UNIT_RATE_BASE_OFFSET,

[TS migration] Migrate WorkspaceReimburse Page #35399

[TS migration] Migrate WorkspaceReimburse Page #35399

Conversation

ruben-rebelo commented Jan 30, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 30, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Feb 13, 2024

Ollyws commented Feb 15, 2024

Ollyws commented Feb 16, 2024

Ollyws commented Feb 22, 2024

ruben-rebelo commented Feb 22, 2024

Ollyws commented Feb 23, 2024

Ollyws commented Feb 27, 2024

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Feb 27, 2024

Ollyws commented Feb 27, 2024

ruben-rebelo commented Mar 4, 2024

Ollyws commented Mar 4, 2024

tylerkaraszewski commented Mar 13, 2024

ruben-rebelo commented Mar 18, 2024

tylerkaraszewski commented Mar 18, 2024

tylerkaraszewski commented Mar 20, 2024

ruben-rebelo commented Mar 21, 2024

tylerkaraszewski commented Mar 21, 2024

fabioh8010 commented Mar 22, 2024

ruben-rebelo commented Mar 22, 2024

OSBotify commented Mar 22, 2024